cleanup(core): move esbuild to use fdir/picomatch #28037
+30
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
27 tasks
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 20a560a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution
✅ Successfully ran 3 targetsSent with 💌 from NxCloud. |
JamesHenry
requested changes
Sep 23, 2024
|
No worries, I'll have a look soon 👍 Will catch the branch up too |
43081j
force-pushed
the
esbuild-fdir
branch
from
fe5966f
to
1080c1d
Compare
43081j
force-pushed
the
esbuild-fdir
branch
from
1080c1d
to
ca8ff73
Compare
|
Please ignore the react rspack module federation e2e error, it will be resolved when you sync with latest master. The others might be legit though |
43081j
force-pushed
the
esbuild-fdir
branch
from
ca8ff73
to
c59a4d7
Compare
43081j
force-pushed
the
esbuild-fdir
branch
from
c59a4d7
to
726d35e
Compare
Migrates away from fast-glob to `fdir` and `picomatch`, a faster and smaller combination.
43081j
force-pushed
the
esbuild-fdir
branch
from
726d35e
to
20a560a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates away from fast-glob to
fdirandpicomatch.this'll improve performance a fair amount (fdir is much faster than fast-glob) and should reduce the install size (picomatch and fdir are both very small).
fast-glob uses micromatch, while this uses picomatch. the difference seems to be that more advanced bash brace expansion isn't supported in picomatch. if that's important to you, its possible we could use micromatch or zeptomatch